Fix LiqidWave 1.5.0 crash when trying to load commonShared module
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea why they're attempting to load a script in the textures directory of all places, but whatever
SkyLeite
changed the title
sharedCommon modulecommonShared module
|
I do not agree that this is something that should be fixed on the game logic/C++ side of things. Unless the skin has a very good reason for putting scripts outside the script folder. |
|
That's fair enough, I'm ok with deferring this as a skin issue in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea why they're attempting to load a script in the textures directory of all places, but whatever.
Fixes #652