Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTHER] remove proptype in nav.jsx #670

Closed
Dun-sin opened this issue Aug 18, 2024 · 3 comments · Fixed by #674
Closed

[OTHER] remove proptype in nav.jsx #670

Dun-sin opened this issue Aug 18, 2024 · 3 comments · Fixed by #674
Assignees
@damirgros
Labels
2 days Not more than 2 days to raise a PR assigned Easy Easy to work on EddieHub:good-first-issue frontend this issue requires knowlegde of frontend good first issue Good for newcomers hacktoberfest 🏁 status: ready for dev issue is ready to be worked on

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 18, 2024 •
edited
Loading

What would you like to share?

Whisper/client/src/components/NavBar.jsx

Lines 161 to 163 in dbec99c

NavBar.propTypes = {
className: PropTypes.string,
};

@Dun-sin Dun-sin added good first issue Good for newcomers EddieHub:good-first-issue Easy Easy to work on up for grabs anyone can ask to work on this hacktoberfest frontend this issue requires knowlegde of frontend 2 days Not more than 2 days to raise a PR 🏁 status: ready for dev issue is ready to be worked on labels Aug 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you.

@damirgros
Copy link
Contributor

Hello, can I take on this issue?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 19, 2024

Hello, can I take on this issue?

Sure, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

@Dun-sin Dun-sin added assigned and removed up for grabs anyone can ask to work on this labels Aug 19, 2024
@damirgros damirgros mentioned this issue Aug 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damirgros damirgros

Labels
2 days Not more than 2 days to raise a PR assigned Easy Easy to work on EddieHub:good-first-issue frontend this issue requires knowlegde of frontend good first issue Good for newcomers hacktoberfest 🏁 status: ready for dev issue is ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove nav proptype (#670)
2 participants
@Dun-sin @damirgros