Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize support breaks precompilation #20

Open
ChrisRackauckas opened this issue Aug 5, 2022 · 6 comments
Open

Resize support breaks precompilation #20

ChrisRackauckas opened this issue Aug 5, 2022 · 6 comments

Comments

@ChrisRackauckas
Copy link

https://github.com/SciML/SciMLSensitivity.jl/runs/7694025968?check_suite_focus=true#step:6:942

The recent release seems to be broken. Does it need to be yanked?

@visr
Copy link
Contributor

visr commented Aug 5, 2022

I noticed the same thing. #19 should fix it if it can be merged and tagged quickly, otherwise a yank would be good.

@YingboMa has a different fix in #21, though I believe my smaller patch is sufficient.

@YingboMa
Copy link
Contributor

YingboMa commented Aug 5, 2022

The code unnecessarily defines extra methods. I fixed that in my patch as well.

@MichelJuillard
Copy link
Member

Sorry about that. I merged #19 and bumped to v1.2.1. I will let @louisponet look at #21

@louisponet
Copy link
Collaborator

Thanks guys, indeed there were unnecessary code redefinitions. It’s interesting that this didn’t pop up in our tests or also when I am using FastLapackInterface on my desktop with v1.8.0-rc3. Any ideas why that is?

@MichelJuillard
Copy link
Member

Thanks to all involved. I have now merged #21 and bumped to version v1.2.2

@MichelJuillard
Copy link
Member

I reopen as the issue of why we didn't see it with our tests remains open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants