-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow QR factorization with no columns. #39
Comments
Yes, I will allow for 0-column matrix. Do you happen to know why Julia implementation of |
Thanks! Regarding zero-row matrices in Julia's standard lib, I have no idea why they are not permitted. import LinearAlgebra as LA
A = Matrix{Float64}(undef, 0, 10)
T = Matrix{Float64}(undef, 0, 0)
qr = LA.QRCompactWY(A, T) and |
I will also allow for 0-row matrix and empty matrix. But, yes please, raise the issue in the Julia repo or on slack #linear-algebra |
I have pushed branch https://gitlhub.com/DynareJulia/FastLapackInterface.jl/tree/zerocolumnrow, that allow for zero column and zero row matrix (or both). |
Looks good to me! The issue came up, when I tried to optimize a routine, where QR factorization is used to determine a “sufficiently independent” set of interpolation/regression points for fully-linear surrogate models. If the initial interpolation set is empty, then there are no columns in the point matrix. |
Closed with commit 7c05eb9 |
The corresponding issue in Julia Linear algebra has been resolved JuliaLang/LinearAlgebra.jl#1054 |
LinearAlgebra
allows for QR decomposition of matrices with column number0
.In
FastLapackInterface
this is prohibited by an assertion inresize!
Removing the assertion still errors, because LAPACK does not like
nb==0
.In the Standard Lib, there is an early return to don't even call
geqrt
, see this lineWe could easily do the same.
The text was updated successfully, but these errors were encountered: