Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untested functions #2

Open
3 tasks
Omar-Elrefaei opened this issue Feb 15, 2023 · 1 comment
Open
3 tasks

Untested functions #2

Omar-Elrefaei opened this issue Feb 15, 2023 · 1 comment

Comments

@Omar-Elrefaei
Copy link
Member

Omar-Elrefaei commented Feb 15, 2023 •
edited
Loading

Currently the following functions are untested as shown by test coverage:

  • a_mul_kron_b!,
  • kron_at_kron_b_mul_c!, and
  • the second signature of At_mul_B! (which is called in the q==1 branches in kron_mul_elem_t!)

testing the commented nested loop at the top of runtests.jl showed some improvements in coverage that pointed me on where to look.

Notably that makes the coverage of ExtendedMul.jl 100%
@MichelJuillard
Copy link
Member

Can you please make the missing tests? For At_mul_B!, wait for your new version of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichelJuillard @Omar-Elrefaei