Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viz.js instead of shelling out to dot #10

Open
forivall opened this issue Apr 5, 2018 · 6 comments
Open

Use viz.js instead of shelling out to dot #10

forivall opened this issue Apr 5, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@forivall
Copy link

forivall commented Apr 5, 2018

The atom graphviz preview plugin uses viz.js instead of the dot cli tool (by default, you can still use the cli tool via an option). It would be neat if you were open to the idea of doing the same! (as in, if someone submitted a PR, it would be considered)

@EFanZh
Copy link
Owner

EFanZh commented Apr 6, 2018

I am open to the idea. But currently the source code is under heavy refactoring and rewriting to adapt to the latest Webview API. PRs will most certainly result in conflicting. Please be patient until the current refactoring work is done.

@forivall
Copy link
Author

forivall commented Apr 9, 2018

Thanks for the info! That's exactly why i open an issue before working on a PR. 😊

@EFanZh
Copy link
Owner

EFanZh commented Apr 28, 2018

Hi @forivall, I think the code structure is somewhat stabilized now. If you are still interested in contributing, you can submitting a pull request now.

@EFanZh EFanZh added the enhancement New feature or request label May 12, 2018
@M0ns1gn0r
Copy link

@forivall Any progress on the PR?

@forivall
Copy link
Author

forivall commented Jul 8, 2019

I'd like to work on it, but I haven't done anything yet. Thanks for the nudge

@GordonSmith
Copy link

I would suggest using @hpcc-js/wasm instead of viz.js (which is archived) as it supports the latest stable version of Graphviz (2.44.1) and is wasm... (disclaimer - I am the author).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants