-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use viz.js instead of shelling out to dot #10
Comments
I am open to the idea. But currently the source code is under heavy refactoring and rewriting to adapt to the latest Webview API. PRs will most certainly result in conflicting. Please be patient until the current refactoring work is done. |
Thanks for the info! That's exactly why i open an issue before working on a PR. 😊 |
Hi @forivall, I think the code structure is somewhat stabilized now. If you are still interested in contributing, you can submitting a pull request now. |
@forivall Any progress on the PR? |
I'd like to work on it, but I haven't done anything yet. Thanks for the nudge |
I would suggest using @hpcc-js/wasm instead of viz.js (which is archived) as it supports the latest stable version of Graphviz (2.44.1) and is wasm... (disclaimer - I am the author). |
The atom graphviz preview plugin uses viz.js instead of the
dot
cli tool (by default, you can still use the cli tool via an option). It would be neat if you were open to the idea of doing the same! (as in, if someone submitted a PR, it would be considered)The text was updated successfully, but these errors were encountered: