Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission access to datasets agnostic to the type of database #21

Closed
SergiAguilo opened this issue Dec 18, 2024 · 4 comments
Closed

Permission access to datasets agnostic to the type of database #21

SergiAguilo opened this issue Dec 18, 2024 · 4 comments

Comments

@SergiAguilo
Copy link
Collaborator

SergiAguilo commented Dec 18, 2024

Hi,

Issue for extending the Ri to other databases:

When you are asking for the datasets available in your database, you are implying here that they are coming from a Mongo Database.
As it can see here, the RI is querying the databases in the mongo connections module.

I suggest making this process as database agnostic as possible.

Thank you,
Sergi

@costero-e
Copy link
Collaborator

Hi @SergiAguilo,

True, I will try to do some workaround to have the datasets being read from the source. Now it's kind of hard-coded.

Thanks for spotting this. I will tell you when I have fixed it.

Best,

Oriol

@costero-e
Copy link
Collaborator

Hi @SergiAguilo,

This issue has been fixed in the PR #23.

Please, check out if this solution works for you.

Best,

Oriol

@costero-e
Copy link
Collaborator

Ah, bear in mind that you will need a function called get_list_of_datasets() inside your datasets.py file to match the one that is being called from permissions for each possible database source.

@SergiAguilo
Copy link
Collaborator Author

Ok, perfect! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants