Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionSetup conversion functions #63

Closed
SebaLukas opened this issue Feb 10, 2025 · 4 comments · Fixed by #84
Closed

SessionSetup conversion functions #63

SebaLukas opened this issue Feb 10, 2025 · 4 comments · Fixed by #84
Assignees
Labels
EV EV side implementation

Comments

@SebaLukas
Copy link
Collaborator

SebaLukas commented Feb 10, 2025

Todo:

  • Adding missing conversion function in src/iso15118/message/session_setup.cpp
  • Adding unit test to test the new conversion functions in test/exi/cb/iso20/session_setup.cpp
@SebaLukas SebaLukas added the EV EV side implementation label Feb 10, 2025
@SebaLukas SebaLukas changed the title [EV] SessionSetup SessionSetup conversion functions Feb 10, 2025
@SebaLukas SebaLukas moved this to Backlog in EV implementation Feb 10, 2025
@SebaLukas SebaLukas moved this from Backlog to Ready in EV implementation Feb 10, 2025
@cienporcien cienporcien moved this from Ready to In progress in EV implementation Feb 12, 2025
@cienporcien
Copy link
Contributor

EV side conversions are added.

@SebaLukas
Copy link
Collaborator Author

The already existing Exi stream for the SessionSetupReq is unfortunately faulty. In this exi stream, the session ID length is zero. But it should be 8.
This would be the correct stream for the same SessionSetupReq message:

{0x80, 0x8C, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x0D, 0x6C, 0xAC, 0x3A, 0x60, 0x62, 0x0B, 0x2B, 0xA6, 0xA4, 0xAB, 0x18, 0x99, 0x19, 0x9A, 0x1A, 0x9B, 0x1B, 0x9C, 0x1C, 0x98, 0x20, 0xA1, 0x21, 0xA2, 0x22, 0xAC, 0x00}

@cienporcien
Copy link
Contributor

I used the basic config-sil-dc-d20.yaml along with the dsV2Gshark wireshark plugin to create new Exi streams for the unit tests, as well as the verbose dsV2Gshark message content for better documentation of the unit tests. Pull request created.

@cienporcien
Copy link
Contributor

Also, I forgot, in order for the EV side conversions to work, this has to be added to variant.cpp:
} else if (doc.SessionSetupRes_isUsed) {
insert_type(va, doc.SessionSetupRes);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EV EV side implementation
Projects
Status: Done
2 participants