[SECENG-1371] Add GHA JIRA ref check in PR title #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebury-sergiorobles
requested review from
DaniGordillo,
jamestait and
ebury-sergiorobles
ebury-sergiorobles
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the audit report Internal Audit: IT Development Governance issued back in May 2023, and in particular recommendation 6.b, we are requested to ensure all GitHub pull requests (PRs) have a linked JIRA ticket to it.
For this reason, we are going to submit a PR to all Ebury repositories creating a GitHub Action that will check the JIRA ticket reference on the PR title with the following format
[JIRA_REF] Some additional text. As an example:[SECENG-1111] This is my PR.See source file for reference.
Note, that this means that current branch protections enforcing status checks to pass before merging will block new PRs not following the new format
See comms and ongoing discussion in Slack here.
This PR has been created by a bot owned by Security Engineering. See it here.