Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writable console #118

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Writable console #118

merged 11 commits into from
Nov 21, 2023

Conversation

DenFlyvendeGed
Copy link
Contributor

Changes/Additions:

Added Console class for printing in the console

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for ecdar ready!

Name Link
🔨 Latest commit d54b2aa
🔍 Latest deploy log https://app.netlify.com/sites/ecdar/deploys/655caf21a1ceff00082a25ab
😎 Deploy Preview https://deploy-preview-118--ecdar.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BaBrixx
Copy link
Contributor

BaBrixx commented Nov 17, 2023

Friendly Nudge: Refining our Code Collaboration Adventure 🚀

Dear @DenFlyvendeGed,

We trust this note finds you in good spirits! 🌸 While perusing our ongoing pull request journey, we couldn't help but notice a gentle hiccup that has introduced an exciting opportunity for refinement.

It appears our PR is currently basking in a moment of peaceful reflection, likely due to the arrival of some merge conflicts that have gracefully taken center stage. 😊 Although the code itself is a sight to behold, we believe we can elevate its brilliance even further with a touch of testing magic. Consider it like sprinkling a bit of enchanting dust to enhance its radiance.

Your efforts are sincerely valued, and we're convinced that a dash of testing magic will make our collaborative creation shine even brighter. However, it seems that our PR might not be quite ready for the grand unveiling just yet.

Your dedication to our collective success is truly commendable, and we appreciate your ongoing efforts. Let's work our magic together and ensure our code collaboration reaches new heights!

Wishing you a day filled with successful coding adventures!

Warm regards,

@NybyDK and @BaBrixx

Copy link
Contributor

@NybyDK NybyDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this pull request include testing or will that be separate?

src/lib/classes/console/Console.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@NybyDK NybyDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are wondering what the plans are for unit testing and end-to-end testing
Will it come later?
p.s. we are not in the grupperum today but you can ping @skrome on Discord

@DenFlyvendeGed
Copy link
Contributor Author

We are wondering what the plans are for unit testing and end-to-end testing Will it come later? p.s. we are not in the grupperum today but you can ping @skrome on Discord

As I said yesterday, I planned writing some playwright test after the functionality was implemented somewhere. That being said I can do some unit tests

@NybyDK
Copy link
Contributor

NybyDK commented Nov 21, 2023

As I said yesterday, I planned writing some playwright test after the functionality was implemented somewhere. That being said I can do some unit tests

Sounds good, I'll make an issue for the end-to-end testing so we don't forget

Edit: #124

Copy link
Contributor

@NybyDK NybyDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenFlyvendeGed DenFlyvendeGed merged commit d0d8876 into main Nov 21, 2023
6 checks passed
@DenFlyvendeGed DenFlyvendeGed deleted the writable-console branch November 21, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants