Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

134 feature code editor 2 #174

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

134 feature code editor 2 #174

wants to merge 16 commits into from

Conversation

KamyaPA
Copy link
Contributor

@KamyaPA KamyaPA commented Dec 14, 2023

Closes #134

Changes/Additions:

Added the code editor to the project.

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for ecdar ready!

Name Link
🔨 Latest commit d650881
🔍 Latest deploy log https://app.netlify.com/sites/ecdar/deploys/657b6d0ca776480008708ad5
😎 Deploy Preview https://deploy-preview-174--ecdar.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KamyaPA KamyaPA requested a review from atjn December 14, 2023 15:34
@KamyaPA
Copy link
Contributor Author

KamyaPA commented Dec 14, 2023

Random Playwright tests fails, do anyone know why

DenFlyvendeGed
DenFlyvendeGed reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@DenFlyvendeGed DenFlyvendeGed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add issue for other editor library that does not start a runtime.

src/lib/components/editor/Editor.svelte Outdated Show resolved Hide resolved
DenFlyvendeGed
DenFlyvendeGed previously approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@DenFlyvendeGed DenFlyvendeGed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atjn atjn Awaiting requested review from atjn

@DenFlyvendeGed DenFlyvendeGed Awaiting requested review from DenFlyvendeGed

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Code editor
2 participants
@KamyaPA @DenFlyvendeGed