40 Implemented dynamic global css variables #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a huge mistake and merge comitted the branch linked to issue #50 into my original CSS branch. This included every individual commits from the other branch into my CSS branch. I tried to revert it but failed and was therefore forced to use this solution.
✅ Deploy Preview for ecdar ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This makes sure that no unsupported CSS variables are used. The supported CSS variables are specified in CSSVariables.ts
…ttps://github.com/ECDAR-AAU-SW-P5/Ecdar-GUI-Web into 40-use-css-variables-for-general-design-secondtry
atjn
requested changes
Nov 2, 2023
src/lib/classes/styling/ZodSchemas/AttributeSchemas/ColorAttribute.ts
Outdated
Show resolved
Hide resolved
atjn
reviewed
Nov 2, 2023
src/lib/classes/styling/ZodSchemas/AttributeSchemas/ColorAttribute.ts
Outdated
Show resolved
Hide resolved
atjn
reviewed
Nov 2, 2023
The zos schemes now enforce: - The color value range - That the "default" mediascheme contains a specification of all specified CSS variables and more...
This was referenced Nov 6, 2023
TSKsmiley
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Implemented everything I made a huge mistake and merge comitted the branch linked to issue #50 into my original CSS branch. This included every individual commits from the other branch into my CSS branch. I tried to revert it but failed and was therefore forced to use this solution. * Added dark mode color to edges * Created a CSS variable support check This makes sure that no unsupported CSS variables are used. The supported CSS variables are specified in CSSVariables.ts * Changed resizer size * Removed unnecessary media schemes * Removed mediaFeature check * Corrrect the parsed error type * Removed the passing of the global window variable * Removed the need for range checking by using zod * Improved the zod schemes The zod schemes now enforce: - The color value range - That the "default" mediascheme contains a specification of all specified CSS variables and more... * Fix typo * Did some color styling to the navbar
NybyDK
added a commit
that referenced
this pull request
Nov 10, 2023
* Add systems and components * Maybe this way to rename? * Moved handler so can click if there is no text For example if user names it whitespace it can be hard to rename * Sveltify and add description * Color options Systems and Components files are almost identical * Type * Merge components and systems into 1 file * Drop down menu for project items * Delete ComponentDropDownMenu.svelte * Update ProjectItemDropDownMenu.svelte * Fix periodic check binding in ProjectItems and add dynamic class to ProjectItem * 40 Implemented dynamic global css variables (#89) * Implemented everything I made a huge mistake and merge comitted the branch linked to issue #50 into my original CSS branch. This included every individual commits from the other branch into my CSS branch. I tried to revert it but failed and was therefore forced to use this solution. * Added dark mode color to edges * Created a CSS variable support check This makes sure that no unsupported CSS variables are used. The supported CSS variables are specified in CSSVariables.ts * Changed resizer size * Removed unnecessary media schemes * Removed mediaFeature check * Corrrect the parsed error type * Removed the passing of the global window variable * Removed the need for range checking by using zod * Improved the zod schemes The zod schemes now enforce: - The color value range - That the "default" mediascheme contains a specification of all specified CSS variables and more... * Fix typo * Did some color styling to the navbar * Add IDs to add component and add system buttons in ProjectNav component * css variables * Update project item and dropdown menu components Co-authored-by: Nyby <[email protected]> * Remove unused imports and clean up code. * Fix tests and add new ones Co-authored-by: Nyby <[email protected]> * lint --------- Co-authored-by: Skrome <[email protected]> Co-authored-by: Nyby <[email protected]> Co-authored-by: Bastian Brix <[email protected]> Co-authored-by: Nyby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a huge mistake and merge comitted the branch linked to issue #50 into my original CSS branch. This included every individual commits from the other branch into my CSS branch. I tried to revert it but failed and was therefore forced to use this solution.
Link to original PR
Closes #40
About
This pull request contains the initial implementation of the dynamic loading of CSS colors (And other CSS properties) and is the foundation for one of the features requested by the PO.
The specific feature is the one in-which users should be able to change the color-scheme by themselves.
Features implemented:
Not yet implemented
Link to MDN docs for mediaQuery selector