Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android CI is failing #890

Closed
repi opened this issue Aug 4, 2022 · 3 comments · Fixed by #891
Closed

Android CI is failing #890

repi opened this issue Aug 4, 2022 · 3 comments · Fixed by #891
Labels
t: bug Something isn't working

Comments

@repi
Copy link
Contributor

repi commented Aug 4, 2022

Our CI is failing on Android with:

Build WGPU example for Android
  Warning: You use environment variable ANDROID_HOME that is deprecated. Please, remove it and use ANDROID_SDK_ROOT instead. Now ANDROID_HOME is used
  Error: Android NDK is not found. Please set the path to the Android NDK with $ANDROID_NDK_ROOT environment variable.
  Error: Process completed with exit code 1.

Example: https://github.com/EmbarkStudios/rust-gpu/runs/7635577970?check_suite_focus=true

May be related to the following GitHub Action ubuntu image updates:

@repi repi added the t: bug Something isn't working label Aug 4, 2022
@repi
Copy link
Contributor Author

repi commented Aug 4, 2022

This is how we fixed it in the physx repo just now: EmbarkStudios/physx-rs#155

@eddyb can you try similar here, or @oisyn next week when back from vacation

@MarijnS95
Copy link
Contributor

MarijnS95 commented Aug 5, 2022

This is actions/runner-images#5879 (comment), ndk-bundle was deprecated and removed but these useful symlinks were removed by "accident" as well. Should be added back soon!

@eddyb
Copy link
Contributor

eddyb commented Aug 6, 2022

This is how we fixed it in the physx repo just now: EmbarkStudios/physx-rs#155

That repo's CI seems to have been setting ANDROID_NDK_ROOT before, but here we didn't.

Hoping that the GHA fixes @MarijnS95 linked have already been propagated, I forced a re-run of the failing CI job, but before it can even get to the part where it uses the NDK, it now fails building cargo-apk because libc 0.2.127 is broken for the nightly we use.

Even if we unblock cargo-apk specifically, we'll have to be careful to avoid bumping libc:

rust-gpu/Cargo.lock

Lines 1183 to 1185 in 0866cf5

[[package]]
name = "libc"
version = "0.2.112"

(until we rustup again, that is)

I'll try see what I can do for now, maybe cargo +stable install ... will be enough.

EDIT: alright, that does work:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants