Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to "django" as the default setting for "context_behavior" #498

Closed
JuroOravec opened this issue May 16, 2024 · 0 comments · Fixed by #515
Closed

Revert back to "django" as the default setting for "context_behavior" #498

JuroOravec opened this issue May 16, 2024 · 0 comments · Fixed by #515
Assignees

Comments

@JuroOravec
Copy link
Collaborator

JuroOravec commented May 16, 2024

See the thread in #494

TL;DR:

#494 (comment)

I wonder if we should switch back to "django" as the default context_behavior, and have isolated be a mode the we reserve for everyone that want the kind of detailed scope control you are after? I think that might be the best path here, that both gives you the control you want, but does not complicate things for beginners?

and #494 (comment)

I think we should [...] be very specific when in isolated mode, but at the same time switch back to "django" as the default. I fear that the kinds of issues you bring up are for later in a project lifetime, are great for maintainability, but might hinder some people that are getting started and don't (yet) need strict isolation. They can always add it later on.

Notes:

  • Ideally we'd update tests so that those tests that render templates would be would be duplicated to be tested for both the "djagno" and "isolated" settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant