feat: add 6cm mortar option for PS US airborne faction #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I'm merging it into dev first and will release it on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
US faction 60mm mortar selection for the calculator interface. Named it as USA 6cm, to look similar with German name. (fun fact: mortar was designed by French, hence the metric unit!)
As of currently, it has the same parameters as the British 3" mortar. (same ranging inside the game)
I added it as a new button, but maybe this could be integrated with the same existing button for British 3" one? (Just had this idea...)
Well, in any case, quite minor changes to the existing code and I suppose it's question of taste, how to implement it. 😃