Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteLatencyDataProvider not accurate enough #131

Open
saraadams opened this issue Nov 27, 2023 · 0 comments
Open

RemoteLatencyDataProvider not accurate enough #131

saraadams opened this issue Nov 27, 2023 · 0 comments
Labels
type/bug Describes a bug in the codebase.

Comments

@saraadams
Copy link
Collaborator

saraadams commented Nov 27, 2023

RemoteLatencyDataProvider used remote action cache check events to find an upper bound of remote latency.
However, when using --disk_cache, remote action cache check are performed against a local disk, rather than a remote service. This can lead to RemoteLatencyDataProvider returning a too low upper bound for remote operations.

@saraadams saraadams added the type/bug Describes a bug in the codebase. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Describes a bug in the codebase.
Projects
None yet
Development

No branches or pull requests

1 participant