Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockHash overhaul #10

Closed
nmccarty opened this issue Jan 6, 2022 · 0 comments · Fixed by #19
Closed

BlockHash overhaul #10

nmccarty opened this issue Jan 6, 2022 · 0 comments · Fixed by #19
Assignees
@DieracDelta

Comments

@nmccarty
Copy link
Contributor

nmccarty commented Jan 6, 2022

The current BlockHash type should be broken into a number of types.

A core Hash type that provides a redacted type implementation, using serde_bytes, and providing a hex-based debug/display impl
A number of type-stating wrapper types such as BlockHash, LeafHash, TransactionHash, etc, to avoid confusion of hash types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DieracDelta DieracDelta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BlockHash Refactor EspressoSystems/HotShot
2 participants
@nmccarty @DieracDelta