Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotShot logging for better debugging experience #3962

Open
pls148 opened this issue Dec 12, 2024 · 0 comments
Open

HotShot logging for better debugging experience #3962

pls148 opened this issue Dec 12, 2024 · 0 comments
Assignees

Comments

@pls148
Copy link
Contributor

pls148 commented Dec 12, 2024

Salman Zulip

  • I think we should log the last view we received a (valid) vote from each node. We can add a field to VoteCollectorsMap to store this internally as a BTreeMap<stake table entry/public key, u64> in VoteCollectionTaskState (?), and update it when handling votes. might not even have to store the view, it coudl be a simple counter that we reset whenever we get a vote and increment when we produce a cert without that node's vote

    whenever we produce a cert we can print nodes that haven't sent us a vote e.g. >10 times in a row

  • we should also find some way to log unsatisfied dependencies when we fail to vote/propose, so we can easily tell from the logs what we were missing. I think this log should print whenever we cancel a vote/propose task for an older view, or when we send a timeout vote

@pls148 pls148 self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant