[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Pay someone - App crashes after paying someone and opening chat header in transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Go to + > Pay
4. Enter amount > Pay elsewhere
5. Immediately click on the expense preview and then the chat header after paying the money
6. Wait until the app crashes

Expected Result:

App will not crash

Actual Result:

App crashes after paying someone and opening chat header in transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521357_1719047085756.crash.mp4

logs (2).txt

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@dangrous FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ishpaul777]

Offending PR - #43251

---

Possible solution to fix crash:
we need to default parentReportID and reportID to -1 instead of empty string.

App/src/pages/ReportDetailsPage.tsx

Lines 82 to 83 in 425804a

	const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID ?? ''}`);
	const [sortedAllReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID ?? ''}`, {

[ikevin127]

cc @cdOut If this is indeed caused by our PR, looks like we missed adding the right fallback value there ^.

[dangrous]

@ikevin127 @cdOut let us know when this is ready for a look!

[cdOut]

@dangrous the PR is mentioned here and ready for review.

[ikevin127]

PR was ✅ Approved - ready for final review & merge!

[cdOut]

Fixed in this PR.

[dangrous]

As noted on the other PR ^, this should be fixed by #44279

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump Onyx to 2.0.53 #44279

If no regressions arise, payment will be issued on 2024-07-02. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[dangrous]

Closing this out since payment will be handled in the other regression issue.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump Onyx to 2.0.53 #44279

If no regressions arise, payment will be issued on 2024-07-10. 🎊