Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [Search v2.1] [POLISH] Prevent duplicate API request #46577

Closed
luacmartins opened this issue Jul 31, 2024 · 5 comments
Closed

[$250] [Search v2.1] [POLISH] Prevent duplicate API request #46577

luacmartins opened this issue Jul 31, 2024 · 5 comments
Assignees
@luacmartins @isabelastisser @rayane-djouah
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 31, 2024 •
edited by melvin-bot bot
Loading

Problem

Every time we load the Search page, we send duplicate API requests

Why is this important

Redundant work that affects performance.

Solution

Figure out why it happens and prevent it

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0128535b0452230f32
  • Upwork Job ID: 1818648879669376154
  • Last Price Increase: 2024-07-31
  • Automatic offers:
    • rayane-djouah | Contributor | 103341544
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 31, 2024
@luacmartins luacmartins self-assigned this Jul 31, 2024
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Jul 31, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.1] [POLISH] Prevent duplicate API request [$250] [Search v2.1] [POLISH] Prevent duplicate API request Jul 31, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 31, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0128535b0452230f32

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 31, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 31, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 31, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 31, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 31, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@luacmartins luacmartins mentioned this issue Jul 31, 2024
Merged
48 tasks
@luacmartins luacmartins moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Jul 31, 2024
@rayane-djouah
Copy link
Contributor

Sorry for the hassle. This is expected in Dev environment because of StrictMode and will never happen in prod - #46481 (comment). I think we can close this.

@github-project-automation github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in [#whatsnext] #expense Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@isabelastisser isabelastisser

@rayane-djouah rayane-djouah

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
[#whatsnext] #expense
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luacmartins @isabelastisser @getusha @rayane-djouah