Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] Chat - 'Up Arrow' Doesn't Open Edit Modal for Message with Thread #46663

Closed
2 of 6 tasks
izarutskaya opened this issue Aug 1, 2024 · 14 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to any chat and write a message.
  2. Reply to that message and click on the header.
  3. Click on 'Leave.'
  4. Click on the 'Up Arrow.'

Expected Result:

The 'Up Arrow' should open the edit modal for the parent message that has a thread.

Actual Result:

The 'Up Arrow' doesn't open the edit modal for messages that have a thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6559121_1722510613111.Screen_Recording_2024-08-01_at_3.49.26_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b9f50804317eebf8
  • Upwork Job ID: 1819059178812692898
  • Last Price Increase: 2024-08-01
Issue OwnerCurrent Issue Owner: @rayane-djouah
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb

@youssef-lr youssef-lr added Daily KSv2 and removed DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 1, 2024
@youssef-lr
Copy link
Contributor

This is a pretty minor bug so demoting, one has to leave a thread first before they can't edit using the arrow.

@youssef-lr youssef-lr added the External Added to denote the issue can be worked on by a contributor label Aug 1, 2024
@melvin-bot melvin-bot bot changed the title Chat - 'Up Arrow' Doesn't Open Edit Modal for Message with Thread [$250] Chat - 'Up Arrow' Doesn't Open Edit Modal for Message with Thread Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b9f50804317eebf8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

@youssef-lr youssef-lr changed the title [$250] Chat - 'Up Arrow' Doesn't Open Edit Modal for Message with Thread [$125] Chat - 'Up Arrow' Doesn't Open Edit Modal for Message with Thread Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

Upwork job price has been updated to $125

@anaskhraza
Copy link

Not able to reproduce this on staging. Up arrow works fine for me

@oscarguinane
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~017275408a967b697f

Unable to reproduce based on those steps, operating system and browser version.

Screen.Shot.2024-08-01.at.5.37.52.PM.-.converted.mp4

Copy link

melvin-bot bot commented Aug 1, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@oscarguinane
Copy link

To be clear, I can’t reproduce it in staging, production or local dev ENVs

@oscarguinane
Copy link

In Chrome or Safari

@alexpensify
Copy link
Contributor

Thanks, @youssef-lr, for noting that there is no action here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants