[HOLD for payment 2025-01-07] Infinite loading on downgrade button if a secondary admin tries to downgrade plan

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11 pro/chrome
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Invite a member and make the member an admin
4. As the admin go to the profile of the workspace
5. Upgrade the plan to a control workspace
6. Downgrade the plan to a collect workspace

Expected Result:

Secondary admin is able to downgrade

Actual Result:

Infinite loading on the downgrade button

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701556_1735000969548.bandicam_2024-12-24_03-39-41-328.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[techievivek]

Seems like a backend bug to me, just finishing up my PR for Hubspot integration then I can take a look into it.

[DylanDylann]

Agree that it is a BE problem. But we also need to adjust a minor thing in the FE, I have created a PR to do that

cc @jayeshmangwani

[techievivek]

Ok, just tested this flow and this is the backend response I am seeing.

[techievivek]

@carlosmiceli Are you working on the design doc for this feature? I think we should probably introduce a new command since we need to use Onyx::handleException here https://github.com/Expensify/Web-Expensify/blob/6b67a5831630e274a3161633a7113c4517fa0de6/lib/PolicyAPI.php#L5653, since we need to populate the error data in onyx.

[techievivek]

Going to remove the deployblocker label since this is expected we just need to surface the error.

[techievivek]

I'm not sure if there has been any discussion about introducing a new command for the newDot use case. I'll go ahead and assign this to you, @carlosmiceli. Let me know if you need any help with this.

[carlosmiceli]

Yes, you're right about everything you mention here @techievivek. We decided to adjust the current command, but it was only when we hooked up the API that we noticed the multiple Auth calls as well. It's next on my list 🙏

[carlosmiceli]

@techievivek I'm realizing that it may take a while before I can build the new command, so I wonder if you agree that we could implement some temporary FE fix to deal with the error response?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update correct field #54501

If no regressions arise, payment will be issued on 2025-01-07. 🎊

[melvin-bot]

@carlosmiceli @laurenreidexpensify @carlosmiceli The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[laurenreidexpensify]

@carlosmiceli @techievivek it looks like @jayeshmangwani and @DylanDylann did work on this PR - can you confirm if any payment is due here? Thanks

[jayeshmangwani]

@laurenreidexpensify There’s no payment due for us at the moment, as this is part of the workspace downgrade project and payment will be handled collectively at the end.

[laurenreidexpensify]

Okay great - am closing this issue out then. Thanks !