Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Expense - From expense report page tapping app's back button navigated to Workspace chat page #54508

Closed
1 of 8 tasks
IuliiaHerets opened this issue Dec 24, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Money Requests

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap fab - new workspace
  3. Create 2 expenses
  4. Open the expense and navigate to the report page
  5. Tap the app's back button

Expected Result:

From expense report page tapping app's back button user must be navigated to workspace chat page.

Actual Result:

From expense report page tapping app's back button user navigated to LHN instead workspace chat page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701609_1735009424228.Screenrecorder-2024-12-24-08-26-44-483_compress_1.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Dec 24, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 24, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 24, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Beamanator
Copy link
Contributor

Looooks like the same as #54496

This comment was marked as off-topic.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 24, 2024
@daledah
Copy link
Contributor

daledah commented Dec 24, 2024

It can be fix in this #54511

@Beamanator
Copy link
Contributor

PR Merged & CP'd, waiting on test!

@kavimuru
Copy link

Bug is not reproduced

SamsungA224g_Chrome_Android13.mp4

@Beamanator Beamanator removed Reviewing Has a PR in review DeployBlockerCash This issue or pull request should block deployment labels Dec 25, 2024
@Beamanator
Copy link
Contributor

Nice! Fixed, so closing this out

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 26, 2024
@melvin-bot melvin-bot bot changed the title Expense - From expense report page tapping app's back button navigated to Workspace chat page [HOLD for payment 2025-01-02] Expense - From expense report page tapping app's back button navigated to Workspace chat page Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-02. 🎊

Copy link

melvin-bot bot commented Dec 26, 2024

@Beamanator @sakluger @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 31, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-01-02] Expense - From expense report page tapping app's back button navigated to Workspace chat page [HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Expense - From expense report page tapping app's back button navigated to Workspace chat page Dec 31, 2024
Copy link

melvin-bot bot commented Dec 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-07. 🎊

Copy link

melvin-bot bot commented Dec 31, 2024

@Beamanator @sakluger @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants