perf(UnityIntegration): only reload assemblies that changed

To prevent Unity from reloading assemblies that weren't changed this change introduces a check to only notify Unity when an assembly was modified.
ExtendRealityLtd · Feb 24, 2019 · 354296a · 354296a
1 parent 164877f
commit 354296a
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/Sources/FodyRunner.UnityIntegration/EditorWeaver.cs b/Sources/FodyRunner.UnityIntegration/EditorWeaver.cs
@@ -27,6 +27,7 @@ private static void ManuallyWeaveAllAssemblies()
         private static void WeaveAllAssemblies()
         {
             EditorApplication.LockReloadAssemblies();
+            bool didChangeAnyAssembly = false;
 
             try
             {
@@ -42,16 +43,22 @@ private static void WeaveAllAssemblies()
                     }
 
                     string sourceFilePath = assembly.sourceFiles.FirstOrDefault();
-                    if (sourceFilePath != null)
+                    if (sourceFilePath == null)
                     {
-                        AssetDatabase.ImportAsset(sourceFilePath, ImportAssetOptions.ForceUpdate);
+                        continue;
                     }
+
+                    AssetDatabase.ImportAsset(sourceFilePath, ImportAssetOptions.ForceUpdate);
+                    didChangeAnyAssembly = true;
                 }
             }
             finally
             {
                 EditorApplication.UnlockReloadAssemblies();
-                AssetDatabase.Refresh();
+                if (didChangeAnyAssembly)
+                {
+                    AssetDatabase.Refresh();
+                }
             }
         }