Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaring a default adapter for all entrypoints of a mod #452

Open
liach opened this issue Jun 24, 2021 · 0 comments
Open

Declaring a default adapter for all entrypoints of a mod #452

liach opened this issue Jun 24, 2021 · 0 comments

Comments

@liach
Copy link
Contributor

liach commented Jun 24, 2021

So when mods are using custom entrypoint adapters, they need to declare the adapter for every entrypoint usage. However, it is quite likely that a mod would use a specific adapter for most of their entrypoints than using many different specific overrides (e.g. language-specific adapters, adapter that pass mod container instances to entrypoints if possible, adapter that reads a custom entrypoint notation). Thoughts?

This feature should be quite easy to implement, and I would volunteer if the idea is accepted and the json key is determined. I recommend defaultLanguageAdapter, so we may have:

{
  ...
  "defaultLanguageAdapter": "kotlin",
  "entrypoints": {
    "main": [
      // Now this is a list of class name than objects, way shorter
    ]
  }
}

It's just as simple as replacing

to the new key's associated value.

@sfPlayer1 for evaluation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant