Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.yml file unclear #12

Open
ChonoOG opened this issue Oct 23, 2024 · 4 comments
Open

Config.yml file unclear #12

ChonoOG opened this issue Oct 23, 2024 · 4 comments

Comments

@ChonoOG
Copy link

ChonoOG commented Oct 23, 2024

Hi,

I’m attempting to install Falconhound, but I’m encountering some unclear information. According to the config.yml-sample, when using a keyvault, we need to configure the appSecret for the keyvault. Could you clarify whether this refers to the name of the secret or the literal value of the secret?

Additionally, when configuring it with the keyvault, is the configuration under # Add your Sentinel connection information here still necessary?

@tmolbergen
Copy link
Contributor

Ref question 1,
The usage of keyvault assumes you are using a service principal to authenticate towards the azure keyvault. So the answer is yes, you do need to define the literal secret value. The rest of the secrets can be stored safely in the azure keyvault.

Ref question 2,
If you define to use an azure keyvault, you can omit defined any of the remaining variables as long as they are stored in the azure keyvault. There is also support for mixed set of credentials. Say you want to have your MDE info in your config file but your Sentinel info in the keyvault (that would also work).

@ChonoOG
Copy link
Author

ChonoOG commented Dec 16, 2024

Ref question 1, The usage of keyvault assumes you are using a service principal to authenticate towards the azure keyvault. So the answer is yes, you do need to define the literal secret value. The rest of the secrets can be stored safely in the azure keyvault.

Why is it necessary to include the literal value of the secret in the configuration file? Doesn’t this defeat the purpose of using Azure Key Vault to securely store secrets?

@tmolbergen
Copy link
Contributor

The litteral value is needed for FalconHound to be able to fetch its secrets from the keyvault. I don't know the intention behind the implementation. If I were to guess im assuming it has something to do with large corporations have multiple tenants and FalconForce is asked to do an audit? Possibly simpler to provide access to the keyvault than giving out all the various credentials for the other applications? (Yes I know you can fetch the secret using the keyvault which leads me to im unsure of the intension)

I sent a pull request to include support for managed identity which should allow you to use an azure keyvault without supplying client id / client secret for authentication.

@olafhartong
Copy link
Contributor

the initial intention was to add support for a client that ran FalconHound on a non-Azure system where it required access to the credentials in the keyvault which were managed by another team.

Yes there are still some credentials in the config but often this is an acceptable tradeoff most teams. The data handled is very sensitive as well and these machines should be properly isolated.

I've just merged Tor's PR which allows for Managed System Identity support to access the key vaults. I'll also work on supporting MSI's to access other Azure based resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants