Propagate current trace and span ids through LogEvent #409
+140
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields are essential for tracing and correlating log messages. It also included in default Serilog JsonFormatter: https://github.com/serilog/serilog/blob/dev/src/Serilog/Formatting/Json/JsonFormatter.cs#L74-L84
|
Hi @consulting-dev, I'll look into this during the week. |
…orrectly implements support for distributed tracing
…og correctly implements support for distributed tracing
|
Thank you for approving and merging. |
|
Right about now :-) It's validating, in a few minutes it will be official. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Activity class is essential part of distributed tracing and log correlation, see: https://learn.microsoft.com/en-us/dotnet/core/diagnostics/distributed-tracing.
Activity class by default is created for each asp net request. It produces fields like TraceId and SpanId which helps to identify and correlate calls across multiple services (its automatically included by HttpClient as well) without writing any additional code.
So far emitting these fields was implemented few years ago in Serilog JsonFormatter, see: https://github.com/serilog/serilog/blob/dev/src/Serilog/Formatting/Json/JsonFormatter.cs#L74-L84 .
In my opinion - Http text formatters should also include these fields by default without a need to make custom overrides.