Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue limit in non-durable sink should be defined in byte size #226

Merged
merged 5 commits into from
Nov 6, 2021

Conversation

FantasticFiasco
Copy link
Owner

Fixes #203

@FantasticFiasco FantasticFiasco force-pushed the feat/queue-limit-in-bytes branch from 3fbb401 to 07a2560 Compare November 6, 2021 14:44
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #226 (07461d3) into master (27d213f) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   90.85%   91.02%   +0.16%     
==========================================
  Files          29       29              
  Lines         875      880       +5     
==========================================
+ Hits          795      801       +6     
+ Misses         80       79       -1     
Impacted Files Coverage Δ
...og.Sinks.Http/LoggerSinkConfigurationExtensions.cs 100.00% <100.00%> (ø)
...nks.Http/Sinks/Http/Private/NonDurable/HttpSink.cs 92.68% <100.00%> (ø)
...ttp/Sinks/Http/Private/NonDurable/LogEventQueue.cs 100.00% <100.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d213f...07461d3. Read the comment docs.

@FantasticFiasco FantasticFiasco merged commit c6f38e6 into master Nov 6, 2021
@FantasticFiasco FantasticFiasco deleted the feat/queue-limit-in-bytes branch November 6, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue limit in non-durable sink should be defined in byte size
1 participant