Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default batch formatter #235

Merged
merged 4 commits into from
Dec 18, 2021

Conversation

FantasticFiasco
Copy link
Owner

Remove DefaultBatchFormatter in favour of promoting ArrayBatchFormatter to default batch formatter.

Fixes #178

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #235 (fa2c48e) into master (833fca5) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   92.64%   92.98%   +0.34%     
==========================================
  Files          29       28       -1     
  Lines         897      884      -13     
==========================================
- Hits          831      822       -9     
+ Misses         66       62       -4     
Impacted Files Coverage Δ
...og.Sinks.Http/LoggerSinkConfigurationExtensions.cs 100.00% <100.00%> (ø)
....Http/Sinks/Http/Private/Durable/HttpLogShipper.cs 86.45% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833fca5...fa2c48e. Read the comment docs.

@FantasticFiasco FantasticFiasco merged commit 870a200 into master Dec 18, 2021
@FantasticFiasco FantasticFiasco deleted the fix/remove-default-batch-formatter branch December 18, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should ArrayBatchFormatter be the default batch formatter?
1 participant