Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 questions to foundations #208

Merged
merged 10 commits into from
Apr 4, 2024
Merged

Add 2 questions to foundations #208

merged 10 commits into from
Apr 4, 2024

Conversation

Andresmup
Copy link
Contributor

@Andresmup Andresmup commented Apr 3, 2024 •
edited
Loading

PR Type

  • Adding new question(s)

Warning: We do not support the inclusion of questions directly copied from official GitHub certification exams. Please only submit original questions and content that you have created.

  • Other content changes (updating questions, answers, explanations or study resources)
  • Code changes (non-content)
  • Documentation changes
  • Other

What's new?

Add two questions (104, 105) to Foundations.

Related issue(s)

#90

Screenshots

@github-actions github-actions bot added foundations Related to GitHub Foundations exam content Related to the content of the site labels Apr 3, 2024
FidelusAleksander
FidelusAleksander requested changes Apr 4, 2024
View reviewed changes
Copy link
Owner

@FidelusAleksander FidelusAleksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing again @Andresmup !

I've left small suggestions/fixes. Please re-request review once addressed ✔️

content/questions/foundations/question-104.md Outdated Show resolved Hide resolved
content/questions/foundations/question-105.md Outdated Show resolved Hide resolved
content/questions/foundations/question-105.md Outdated Show resolved Hide resolved
content/questions/foundations/question-105.md Outdated Show resolved Hide resolved
Andresmup
Andresmup commented Apr 4, 2024
View reviewed changes
Copy link
Contributor Author

@Andresmup Andresmup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit changes to update questions done @FidelusAleksander

FidelusAleksander
FidelusAleksander requested changes Apr 4, 2024
View reviewed changes
Copy link
Owner

@FidelusAleksander FidelusAleksander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing and we are good to merge @Andresmup

content/questions/foundations/question-104.md Outdated Show resolved Hide resolved
@Andresmup
Copy link
Contributor Author

@FidelusAleksander done 😃

FidelusAleksander
FidelusAleksander approved these changes Apr 4, 2024
View reviewed changes
Copy link
Owner

@FidelusAleksander FidelusAleksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will get this merged

@FidelusAleksander FidelusAleksander merged commit 22d8f6d into FidelusAleksander:master Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FidelusAleksander FidelusAleksander FidelusAleksander approved these changes

Assignees
No one assigned
Labels
content Related to the content of the site foundations Related to GitHub Foundations exam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andresmup @FidelusAleksander