Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect PGBOUNCER secret password parsing #163

Open
flex-seongbok opened this issue Jan 22, 2024 · 3 comments
Open

Incorrect PGBOUNCER secret password parsing #163

flex-seongbok opened this issue Jan 22, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@flex-seongbok
Copy link

Hi, thanks for maintaining this project.
We encountered problem while testing PgBouncer.

{{- $urlParts := (include "flagsmith.api.realDatabaseUrl" . | trim | urlParse) }}

secrets-pgbouncer.yaml parses databaseUrl using urlParse to get host, database, user, password seperately.
but urlParse escapes url and results in incorrect password configuration
if there is databaseUrl like postgresql://{user}:password!123@{host}:{port}/{database_name}
This url transformed in secrete as password%21(base64 decoded) such as url escaped string
Other special characters could make error at urlParse

@dabeeeenster
Copy link
Contributor

Thanks for the heads up - are you able to provide a PR?

@dabeeeenster dabeeeenster added the bug Something isn't working label Jan 22, 2024
@flex-seongbok
Copy link
Author

Thanks for the heads up - are you able to provide a PR?

I'm not used to writing helm template and go, so not confident that I can write correct patch, sorry.

@dabeeeenster
Copy link
Contributor

OK we will take a look when we have a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants