Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources to migrate-db container #275

Open
AlissonRS opened this issue Sep 18, 2024 · 1 comment
Open

Add resources to migrate-db container #275

AlissonRS opened this issue Sep 18, 2024 · 1 comment

Comments

@AlissonRS
Copy link

When using ArgoCD for deploying Flagsmith, it thinks the cluster is not synced with the chart because it finds a diff, as the migrate-db container doesn't include a resources: {}.

I understand for a migration job which is short lived adding resources may not be relevant enough, but this helps avoiding sync issues with GitOps tools, and may also avoid issues with clusters that require all workloads to have resources defined.

This affects t he deployment-api.yaml (specifically the migrate-db init container) and the jobs-migrate-db.yaml.

image

@rolodato
Copy link
Member

We don't use ArgoCD in production but this sounds reasonable. We'd be happy to accept a pull request for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants