From f9069e41e19e4fdf0faa2a1b006ca55072a98920 Mon Sep 17 00:00:00 2001
From: Zach Aysan <zachaysan@gmail.com>
Date: Thu, 26 Sep 2024 06:19:33 -0400
Subject: [PATCH] feat: Set default billing terms for missing info cache
 (#4614)

---
 api/app_analytics/analytics_db_service.py     | 22 ++++----
 .../test_analytics_db_service.py              | 50 ++++++++++++++-----
 2 files changed, 50 insertions(+), 22 deletions(-)

diff --git a/api/app_analytics/analytics_db_service.py b/api/app_analytics/analytics_db_service.py
index 59933d808966..455c1392f274 100644
--- a/api/app_analytics/analytics_db_service.py
+++ b/api/app_analytics/analytics_db_service.py
@@ -40,22 +40,24 @@ def get_usage_data(
     match period:
         case constants.CURRENT_BILLING_PERIOD:
             if not getattr(organisation, "subscription_information_cache", None):
-                return []
-            sub_cache = organisation.subscription_information_cache
-            starts_at = sub_cache.current_billing_term_starts_at or now - timedelta(
-                days=30
-            )
+                starts_at = now - timedelta(days=30)
+            else:
+                sub_cache = organisation.subscription_information_cache
+                starts_at = sub_cache.current_billing_term_starts_at or now - timedelta(
+                    days=30
+                )
             month_delta = relativedelta(now, starts_at).months
             date_start = relativedelta(months=month_delta) + starts_at
             date_stop = now
 
         case constants.PREVIOUS_BILLING_PERIOD:
             if not getattr(organisation, "subscription_information_cache", None):
-                return []
-            sub_cache = organisation.subscription_information_cache
-            starts_at = sub_cache.current_billing_term_starts_at or now - timedelta(
-                days=30
-            )
+                starts_at = now - timedelta(days=30)
+            else:
+                sub_cache = organisation.subscription_information_cache
+                starts_at = sub_cache.current_billing_term_starts_at or now - timedelta(
+                    days=30
+                )
             month_delta = relativedelta(now, starts_at).months - 1
             month_delta += relativedelta(now, starts_at).years * 12
             date_start = relativedelta(months=month_delta) + starts_at
diff --git a/api/tests/unit/app_analytics/test_analytics_db_service.py b/api/tests/unit/app_analytics/test_analytics_db_service.py
index 88e6fb634fd3..bdf201e374ef 100644
--- a/api/tests/unit/app_analytics/test_analytics_db_service.py
+++ b/api/tests/unit/app_analytics/test_analytics_db_service.py
@@ -385,20 +385,41 @@ def test_get_feature_evaluation_data_calls_get_feature_evaluation_data_from_loca
     )
 
 
-@pytest.mark.parametrize(
-    "period",
-    [
-        CURRENT_BILLING_PERIOD,
-        PREVIOUS_BILLING_PERIOD,
-    ],
-)
-def test_get_usage_data_returns_empty_list_when_unset_subscription_information_cache(
-    period: str,
+@pytest.mark.freeze_time("2023-01-19T09:09:47.325132+00:00")
+def test_get_usage_data_returns_30d_of_60d_when_unset_subscription_information_cache_for_previous_billing_period(
+    mocker: MockerFixture,
+    settings: SettingsWrapper,
+    organisation: Organisation,
+) -> None:
+    # Given
+    period = PREVIOUS_BILLING_PERIOD
+    settings.USE_POSTGRES_FOR_ANALYTICS = True
+    mocked_get_usage_data_from_local_db = mocker.patch(
+        "app_analytics.analytics_db_service.get_usage_data_from_local_db", autospec=True
+    )
+    assert getattr(organisation, "subscription_information_cache", None) is None
+
+    # When
+    get_usage_data(organisation, period=period)
+
+    # Then
+    mocked_get_usage_data_from_local_db.assert_called_once_with(
+        organisation=organisation,
+        environment_id=None,
+        project_id=None,
+        date_start=datetime(2022, 11, 20, 9, 9, 47, 325132, tzinfo=timezone.utc),
+        date_stop=datetime(2022, 12, 20, 9, 9, 47, 325132, tzinfo=timezone.utc),
+    )
+
+
+@pytest.mark.freeze_time("2023-01-19T09:09:47.325132+00:00")
+def test_get_usage_data_returns_30d_when_unset_subscription_information_cache_for_current_billing_period(
     mocker: MockerFixture,
     settings: SettingsWrapper,
     organisation: Organisation,
 ) -> None:
     # Given
+    period = CURRENT_BILLING_PERIOD
     settings.USE_POSTGRES_FOR_ANALYTICS = True
     mocked_get_usage_data_from_local_db = mocker.patch(
         "app_analytics.analytics_db_service.get_usage_data_from_local_db", autospec=True
@@ -406,11 +427,16 @@ def test_get_usage_data_returns_empty_list_when_unset_subscription_information_c
     assert getattr(organisation, "subscription_information_cache", None) is None
 
     # When
-    usage_data = get_usage_data(organisation, period=period)
+    get_usage_data(organisation, period=period)
 
     # Then
-    assert usage_data == []
-    mocked_get_usage_data_from_local_db.assert_not_called()
+    mocked_get_usage_data_from_local_db.assert_called_once_with(
+        organisation=organisation,
+        environment_id=None,
+        project_id=None,
+        date_start=datetime(2022, 12, 20, 9, 9, 47, 325132, tzinfo=timezone.utc),
+        date_stop=datetime(2023, 1, 19, 9, 9, 47, 325132, tzinfo=timezone.utc),
+    )
 
 
 @pytest.mark.freeze_time("2023-01-19T09:09:47.325132+00:00")