Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivariate value UI issues - values don't wrap after exceeding character limit #2243

Closed
matthewelwell opened this issue May 24, 2023 · 4 comments · Fixed by #2612
Closed
Assignees
Labels
bug Something isn't working

Comments

@matthewelwell
Copy link
Contributor

See video demonstration of the issue:

long-mv-value-wrapping.mov

Ideally, values should wrap onto the next line, allowing users to define more complex JSON structures in their multivariate features. Some other alternatives would be:

  1. Fix the width and height and add scroll bar(s). This is not ideal as it makes JSON management very difficult.
  2. Add a secondary modal to edit the value (maybe overkill?)
@matthewelwell matthewelwell added the bug Something isn't working label May 24, 2023
@matthewelwell matthewelwell added this to the Front End ToDo milestone May 24, 2023
@khvn26
Copy link
Member

khvn26 commented May 24, 2023

If we go with option 1, we could think of user-controlled line wrapping which should not be hard to implement.

Additionally, we could integrate something like CodeMirror to fully off-load things like format linting, highlighting, etc.

@dabeeeenster
Copy link
Contributor

Modals on our modals?
image

@dabeeeenster
Copy link
Contributor

If we go with option 1, we could think of user-controlled line wrapping which should not be hard to implement.

Additionally, we could integrate something like CodeMirror to fully off-load things like format linting, highlighting, etc.

Yep might be time for a proper widget for this?

@matthewelwell
Copy link
Contributor Author

Next steps here would be to investigate the issue and determine a feasible solution as per the options suggested in the description (or another option).

@kyle-ssg kyle-ssg linked a pull request Aug 9, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants