fix(roles/org-permission): Add missing viewset #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2495 +/- ##
=======================================
Coverage ? 95.43%
=======================================
Files ? 963
Lines ? 27070
Branches ? 0
=======================================
Hits ? 25834
Misses ? 1236
Partials ? 0 ☔ View full report in Codecov by Sentry. |
api/conftest.py
Outdated
| @@ -328,6 +328,11 @@ def view_project_permission(): | |||
| return PermissionModel.objects.get(key=VIEW_PROJECT) | |||
|
|
|||
|
|
|||
| @pytest.fixture() | |||
| def create_project_permission(): | |||
There was a problem hiding this comment.
I'm not sure why this was moved? It also no longer depends on the db fixture, which I think will break it (if it's used on its own at least).
There was a problem hiding this comment.
To answer the first question: it was not being used. As for the second one: yes, added
matthewelwell
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Bump rbac module to add support for organisation roles permission viewset
How did you test this code?
Covered by rbac module