Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Amplitude integration causes any subsequent additions to fail #2525

Closed
1 of 4 tasks
dannydtk opened this issue Jul 26, 2023 · 3 comments · Fixed by #2531
Closed
1 of 4 tasks

Removing Amplitude integration causes any subsequent additions to fail #2525

dannydtk opened this issue Jul 26, 2023 · 3 comments · Fixed by #2531
Assignees
Labels
bug Something isn't working

Comments

@dannydtk
Copy link

Describe the bug

The first time you add Amplitude integration for a particular Flagsmith environment it's added successfully. If you try to remove it and add it again by clicking Save nothing happens and the underlying request POST https://api.flagsmith.com/api/v1/environments/<env_id>/integrations/amplitude/ fails with 500 Server error.

If you use a fresh environment it works until you try to remove and re-add the integration.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://app.flagsmith.com/project/<project_id>/integrations (Integrations tab)
  2. Add Amplitude integration
  3. Select environment A
  4. Provide valid Amplitude API key
  5. Click on Save
  6. Remove the integration you've just added by clicking the red trash bin icon next to it
  7. Repeat points 3-5 for the same A environment (re-add the integration)
  8. Observe how the Save button is getting disabled and nothing happens. You can see in the network tab POST https://api.flagsmith.com/api/v1/environments/<env_id>/integrations/amplitude/ failing with 500 Server error.

Expected behavior

You can successfully re-add Amplitude integration for the same Flagsmith environment.

How are you running Flagsmith?

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way
@dannydtk dannydtk added the bug Something isn't working label Jul 26, 2023
@dabeeeenster
Copy link
Contributor

dabeeeenster commented Jul 26, 2023

Related: Sentry Issue: FLAGSMITH-API-37S
and closed related PR which was merged #2217

@dannydtk
Copy link
Author

Looks like it was fixed in v2.54.0 but we're still experiencing the issue using the latest v2.63.2 SaaS.

@dannydtk
Copy link
Author

I can also see the changes to serializers from #2217 omitted Amplitude integration.

class AmplitudeConfigurationSerializer(serializers.ModelSerializer):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants