fix: environment webhooks shows current date, not created date #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
gagantrivedi
previously approved these changes
Aug 1, 2023
|
Uffizzi Preview |
Handle nulls in FE
matthewelwell
commented
Aug 1, 2023
Comment on lines
12
to
22
| operations = [ | ||
| migrations.AddField( | ||
| model_name='organisationwebhook', | ||
| name='created_at', | ||
| field=models.DateTimeField(auto_now_add=True, null=True), | ||
| ), | ||
| migrations.AddField( | ||
| model_name='organisationwebhook', | ||
| name='updated_at', | ||
| field=models.DateTimeField(auto_now=True, null=True), | ||
| ), |
There was a problem hiding this comment.
Have you verified (perhaps just with python manage.py sqlmigrate organisations 0043) that it doesn't update existing webhooks?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2555 +/- ##
=======================================
Coverage 95.43% 95.44%
=======================================
Files 972 975 +3
Lines 27190 27221 +31
=======================================
+ Hits 25950 25981 +31
Misses 1240 1240
☔ View full report in Codecov by Sentry. |
|
Need to modify migrations to not set current datetime on application |
dabeeeenster
approved these changes
Aug 1, 2023
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2554
How did you test this code?
Ran locally. Created a webhook, edited the created date. Verified that it showed the correct date.