fix(frontend): Disabled loading indicator when getting featuers so screen doesn't flicker #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ren doesn't flicker
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Aspidites is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
matthewelwell
approved these changes
Aug 17, 2023
This was referenced Aug 17, 2023
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Removed the
store.loadline because that causes the entire page to not render while waiting on results. It also means that on a failed search, the input becomes unresponsive. It wasn't clear to me while looking through the code what the canonical way (in this code base) is to do local loading indicators, so I left it as a simple 1 line change.How did you test this code?
Manually: