Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions/tags): Add tags support #2685

Merged
merged 9 commits into from
Oct 30, 2023
Merged

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Aug 28, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add tags support to DELETE_FEATURE and UPDATE_FEATURE_STATE using RBAC module

How did you test this code?

Covered by unit test in rbac module

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:25am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:25am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:25am

@github-actions github-actions bot added the api Issue related to the REST API label Aug 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

Uffizzi Preview deployment-39511 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b0ef013) 95.60% compared to head (e38361f) 95.60%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2685   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files        1009     1009           
  Lines       28904    28951   +47     
=======================================
+ Hits        27634    27680   +46     
- Misses       1270     1271    +1     
Files Coverage Δ
api/api_keys/user.py 91.89% <100.00%> (-2.71%) ⬇️
api/environments/permissions/constants.py 100.00% <100.00%> (ø)
api/features/models.py 93.66% <100.00%> (+0.06%) ⬆️
api/permissions/permission_service.py 97.40% <100.00%> (ø)
api/projects/permissions.py 88.15% <100.00%> (+0.15%) ⬆️
...pi/tests/unit/features/test_unit_features_views.py 100.00% <100.00%> (ø)
api/users/models.py 95.07% <100.00%> (ø)
api/features/permissions.py 82.35% <95.23%> (+3.56%) ⬆️
api/permissions/rbac_wrapper.py 67.44% <50.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 78e559c Oct 30, 2023
@gagantrivedi gagantrivedi deleted the feat/tag-based-permissions branch October 30, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants