feat: versioned feature states #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/common/types/requests.ts # frontend/common/types/responses.ts
…' into feature/versioned_feature_states # Conflicts: # frontend/common/types/responses.ts
# Conflicts: # frontend/web/components/SegmentOverrides.js # frontend/web/components/modals/ConfirmToggleEnvFeature.tsx # frontend/web/components/pages/EnvironmentSettingsPage.js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
zachaysan
reviewed
Feb 1, 2024
There was a problem hiding this comment.
- Enable feature versioning settings for "Production" environment and see feature history list.
- Switch to "Development" environment.
- Click on feature history button.
- Shown below error. If scaleup is required then the first environment shouldn't have been enabled. On the other hand if scaleup isn't required then a different message should be displayed when feature versioning isn't enabled for an environment.
# Conflicts: # frontend/common/services/useAuditLogItem.ts # frontend/common/types/responses.ts # frontend/e2e/tests/segment-test.ts # frontend/package-lock.json # frontend/web/components/AuditLog.tsx # frontend/web/routes.js
This is expected, envionments that don't have versioning enabled will be sent to the audit log page. Edit: after discussion, it was decided that it's better to separate audit log and history actions, you can now do either of these. |
|
Above issues are resolved. |
|
OK yep my issues are fixed. Is there anything else blocking this going live? |
zachaysan
reviewed
Feb 9, 2024
Well, yes - this 
(but I love that we have new E2E tests here!) |
# Conflicts: # frontend/common/types/requests.ts # frontend/web/components/tables/TableFilterItem.tsx
|
My bad, was just a duplicate data-test attribute added from latest feedback to split audit log links from versioning links. I think we're good to go when tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
What this does not fully cover, this should follow in an upcoming PR
How did you test this code?
e2e tests that go through creating tests with feature versions enabled to check for regression
Created and updated feature state remote config
Updated feature enabled state
Created a segment override
Update segment override
Note: there is currently an API issue @matthewelwell is looking into.
Update multivariate weightings
Note: this will probably change in the future, different feature versions could technically have totally different multivariate options, this currently only diffs the options that exist in the live feature.