Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send JSON response instead of plain text #2739

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

tushar5526
Copy link
Contributor

@tushar5526 tushar5526 commented Sep 5, 2023

Closes #59
Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Send JSONReponse instead of plain text.

How did you test this code?

make test

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 3:35pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 3:35pm

@vercel
Copy link

vercel bot commented Sep 5, 2023

@tushar5526 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Uffizzi Preview deployment-35221 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.04% 🎉

Comparison is base (55a9ef7) 95.48% compared to head (0103429) 95.52%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
+ Coverage   95.48%   95.52%   +0.04%     
==========================================
  Files         994      993       -1     
  Lines       27939    28007      +68     
==========================================
+ Hits        26677    26754      +77     
+ Misses       1262     1253       -9     
Files Changed Coverage Δ
api/app/settings/common.py 87.95% <ø> (ø)
api/users/views.py 91.21% <50.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/users/views.py Outdated Show resolved Hide resolved
Co-authored-by: Kim Gustyr <[email protected]>
@matthewelwell
Copy link
Contributor

@tushar5526 can you fix the linting errors here?

@tushar5526
Copy link
Contributor Author

@tushar5526 can you fix the linting errors here?

Done!

@dabeeeenster dabeeeenster requested a review from khvn26 September 11, 2023 07:25
@khvn26 khvn26 merged commit cad0cbf into Flagsmith:main Sep 14, 2023
@tushar5526 tushar5526 deleted the json-response branch September 14, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API improvement Improvement to the existing platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have /api/v1/users/init/ return a JSON response or an empty body
5 participants