Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add or remove user and groups from roles #2791

Merged
merged 43 commits into from
Nov 7, 2023

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Sep 19, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add users and roles in the roles modal.
  • Add roles in the edit permission modal for users and groups.
  • Edit permissions for projects and environments in their Settings tab.
  • Added "show_role_management" flag to wrap this features.

How did you test this code?

Manage roles

  • Go to manage -> members.
  • Click the "Roles" tab.
  • Click the "Create Role" button.
  • Create a new role.
  • Select the role in the role list.
  • Edit name and description. (If you want to exit without saving, a confirmation modal will appear.)
  • Edit organisation, project, and environment permissions (If you want to exit or change the tab without saving, a confirmation modal will appear.)
  • Click the trash button to delete the role.

Add a role to a user.

  • Go to Manage -> Members
  • Click the "Edit permissions" button in a user.
  • Click the "Add role" button.
  • Select a role to add it.
  • Click the role to remove it.

Add a role to a Group.

  • Click the "Groups" tab.
  • Click the "Edit permissions" button in a group.
  • Click the "Add role" button.
  • Select a role to add it.
  • Click the role to remove it.

Add a User or Group to a Role.

  • Click the "Roles" tab.
  • Click a role.
  • Click the "Members" tab.
  • Click the "Assign role to User" or "Assign role to Group" button.
  • Select a user or group to add it.
  • Click the user or group to remove it.

Edit role permissions for project settings and environment settings.

  • Go to Project Settings.
  • Click the "Members" tab.
  • Click the "Roles" tab.
  • Click a role.
  • Edit Role.
  • Click the "Save permission" button.

Edit role permissions for environment settings.

  • Go to Environment settings.
  • Click the "Members" tab.
  • Click the "Roles" tab.
  • Click a role.
  • Edit Role.
  • Click the "Save permission" button.

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 7:44pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 7:44pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 7:44pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 19, 2023
frontend/common/types/responses.ts Outdated Show resolved Hide resolved
frontend/web/components/EditPermissions.tsx Outdated Show resolved Hide resolved
frontend/web/components/EditPermissions.tsx Show resolved Hide resolved
frontend/web/components/EditPermissions.tsx Outdated Show resolved Hide resolved
frontend/web/components/EditPermissions.tsx Outdated Show resolved Hide resolved
frontend/web/components/EditPermissions.tsx Outdated Show resolved Hide resolved
frontend/web/components/EditPermissions.tsx Show resolved Hide resolved
frontend/web/components/EditPermissions.tsx Outdated Show resolved Hide resolved
@kyle-ssg
Copy link
Member

kyle-ssg commented Nov 6, 2023

Loads better

Copy link
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vercel is not working for me - approving to unblock @novakzaballa

@novakzaballa novakzaballa added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit c2d0c11 Nov 7, 2023
@novakzaballa novakzaballa deleted the feat/add-or-remove-user-and-groups-from-roles branch November 7, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE changes to add/remove User/Groups to/from Roles
3 participants