fix(tasks): Create a different task to update environment document #2807
Conversation
reduce transaction length to make #2709 more rare and improve wait time
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2807 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 994 994
Lines 28072 28074 +2
=======================================
+ Hits 26818 26820 +2
Misses 1254 1254
☔ View full report in Codecov by Sentry. |
gagantrivedi
changed the title
gagantrivedi
changed the title
api/audit/models.py
Outdated
| self.update_environments_updated_at() | ||
| self.send_environments_to_dynamodb() | ||
| self.send_environment_update_message() | ||
|
|
||
| def update_environments_updated_at(self): |
There was a problem hiding this comment.
This method feels like it could be named better since it's triggering another task to handle the environment update logic. It might also benefit from a docstring I guess?
There was a problem hiding this comment.
But it does update the updated_at
There was a problem hiding this comment.
I guess I can change it back to process_environment_update
gagantrivedi
changed the title
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Create a different task for updating environment document and sending SSE message in order to reduce the transaction length (earlier it was doing all of the above as well in the same transaction)
How did you test this code?
Adds unit tests