Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Shows "Identities" nav element as disabled for users without relevant permission #2813

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix: Shows "Identities" nav element as disabled for users without relevant permission #2813

merged 1 commit into from
Sep 29, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Show the 'Identities' nav element greyed out and disabled when the user haven't 'VIEW_IDENTITIES' permission.
Screen Shot 2023-09-28 at 16 38 19

How did you test this code?

  • Remove 'VIEW_IDENTITIES' permission from a user.

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Sep 28, 2023 8:41pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Sep 28, 2023 8:41pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Sep 28, 2023 8:41pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 28, 2023
@novakzaballa novakzaballa requested review from a team and gagantrivedi September 28, 2023 20:41
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

Uffizzi Preview deployment-37154 was deleted.

@novakzaballa novakzaballa linked an issue Sep 28, 2023 that may be closed by this pull request
Show identities nav element as disabled for users who don't have relevant permissions #2652
Closed
@novakzaballa novakzaballa merged commit 3ec2f6b into main Sep 29, 2023
@novakzaballa novakzaballa deleted the fix/show-identities-nav-element-as-disabled-for-users-without-relevant-permissions branch September 29, 2023 12:52
@dabeeeenster dabeeeenster mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagantrivedi gagantrivedi gagantrivedi approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show identities nav element as disabled for users who don't have relevant permissions
2 participants
@novakzaballa @gagantrivedi