fix: Check that feature owners are able to view the project of a feature #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
=======================================
Coverage 95.63% 95.64%
=======================================
Files 1012 1012
Lines 29139 29154 +15
=======================================
+ Hits 27868 27883 +15
Misses 1271 1271
☔ View full report in Codecov by Sentry. |
matthewelwell
requested changes
Nov 7, 2023
matthewelwell
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Before users from anywhere could be added to a feature as an owner, even if they were outside the organisation. Now, they must be able to view the project of the feature in order to be added as feature owners. This mirrors much of the existing logic around this part of the codebase, but I could be convinced to make it differently. For example, users as members of the organisation could make sense as well.
How did you test this code?
Updated the existing code, watched the formerly passing test fail, then updated the test and added a new one to make sure users can't be added as owners if they're not affiliated with the feature.