feat: Call webhooks async and add backoff to webhooks #2932
Conversation
|
@tushar5526 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Uffizzi Ephemeral Environment
|
tushar5526
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 95.88% 95.82% -0.06%
==========================================
Files 1044 1044
Lines 30663 30723 +60
==========================================
+ Hits 29401 29441 +40
- Misses 1262 1282 +20 ☔ View full report in Codecov by Sentry. |
|
@khvn26 @matthewelwell Earlier this was synchronous, but now webhooks are scheduled at almost the same time with the same constant backoffs. |
There was a problem hiding this comment.
This looks good to me now! Thanks so much for all your hard work on this @tushar5526.
Co-authored-by: Kim Gustyr <[email protected]>
Learned lots of stuff :D, thanks for the high-quality reviews @matthewelwell @khvn26 ! |
|
Resolved the conflicts, good to go! |
|
Just checking if there is anything else in this - that needs a second look ? |
|
cc @khvn26 ! |
|
@tushar5526 sorry for the delay in getting this merged, with the holidays and trying to manage the size of releases it's been waiting on the priorities a little bit. I'm merging it now. Thanks again for the hard work on this one! |
Related to #1654
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Use task processor to exponentially backoff webhooks and make webhook calling process async. Earlier it was a sync for loop.
How did you test this code?
Tested it locally, by running the task processor and running faulty and health webhooks. Also, updated test to support the new changes.