feat: Add manage segment overrides permission in UI #2936
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
|
vercel is not working for me to review this. Maybe @kyle-ssg is a better person to review this? |
| <Permission | ||
| level='project' | ||
| permission={'MANAGE_SEGMENTS'} | ||
| id={this.props.projectId} | ||
| > |
There was a problem hiding this comment.
Shouldn't this permission be MANAGE_SEGMENT_OVERRIDES?
There was a problem hiding this comment.
I was following the advice you left in this comment. #1676 (comment)
In addition to the above, please also hide the Create Feature-Specific Segment button if the user is missing the project permission MANAGE_SEGMENTS since they will not be able to create a segment if that permission is missing.
I thought it made sense.
There was a problem hiding this comment.
Just in case, this button creates a Feature-Specific segment.
There was a problem hiding this comment.
Ahh, of course. Thanks for double checking Novak!
|
Using this branch |
| if (this.state.selectedSegment) { | ||
| this.props.setShowCreateSegment(false) | ||
| } else { | ||
| this.props.setShowCreateSegment(false) |
There was a problem hiding this comment.
I think you can remove the if-else statement here and stick to just one if statement, since both branches of the if-else statement call the same thing.
There was a problem hiding this comment.
Good catch, this is not my code, it is a change in the format, but we can optimize it. Done.
novakzaballa
deleted the
feat/add-manage-segment-overrides-permission-in-ui
branch
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
How did you test this code?