fix: Fix evironment metadata N+1 for environments list

[zachaysan]

Thanks for submitting a PR! Please check the boxes below:

• I have run pre-commit to check linting
• I have filled in the "Changes" section below?
• I have filled in the "How did you test this code" section below?
• I have used a Conventional Commit title for this Pull Request

Changes

Isolated the cause of an N+1 query and implemented a fix without forcing it on every caller. We may want to consider reviewing the callers and seeing which of them load metadata as well, since the bulk of the performance enhancement is already complete.

How did you test this code?

One new test. During the testing process I also manually inspecting the types of queries that were generated to ensure that they matched those reported by Sentry.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2023 8:44pm
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2023 8:44pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2023 8:44pm

[github-actions]

Uffizzi Preview deployment-40416 was deleted.

[gagantrivedi]

Think we should try to add new tests under the tests directory only. The tests here should live under /tests/unit/environment/test_views, right @matthewelwell ?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d16197) 95.64% compared to head (b08931b) 95.68%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
+ Coverage   95.64%   95.68%   +0.04%     
==========================================
  Files        1012     1011       -1     
  Lines       29173    29197      +24     
==========================================
+ Hits        27902    27938      +36     
+ Misses       1271     1259      -12     

Files	Coverage Δ
api/conftest.py	98.83% <ø> (+2.32%)	⬆️
api/environments/views.py	96.69% <ø> (+4.13%)	⬆️
api/permissions/permission_service.py	97.50% <100.00%> (+0.09%)	⬆️
.../unit/environments/test_unit_environments_views.py	100.00% <100.00%> (ø)
api/users/models.py	95.07% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zachaysan]

Think we should try to add new tests under the tests directory only. The tests here should live under /tests/unit/environment/test_views, right @matthewelwell ?

Sounds good. I've moved all the tests into the target file, including the one I wrote.