Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent sentry errors for on premise subscriptions #2948

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Changes the log message to warning to stop sending events to Sentry when an on-premise enterprise subscription is created in Chargebee.

How did you test this code?

Updated unit test.

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 9, 2023 4:57pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 4:57pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 4:57pm

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Uffizzi Preview deployment-40423 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0eefdd) 95.64% compared to head (76f1066) 95.64%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2948   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files        1012     1012           
  Lines       29154    29182   +28     
=======================================
+ Hits        27883    27911   +28     
  Misses       1271     1271           
Files Coverage Δ
api/organisations/tests/test_views.py 100.00% <100.00%> (ø)
api/organisations/views.py 91.39% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 6f830e2 Nov 9, 2023
@matthewelwell matthewelwell deleted the fix/stop-sentry-alerts-for-ent-subscriptions branch November 9, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants