-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce dunning billing status #2976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2976 +/- ##
==========================================
- Coverage 95.58% 95.56% -0.02%
==========================================
Files 1016 1019 +3
Lines 29526 29668 +142
==========================================
+ Hits 28222 28352 +130
- Misses 1304 1316 +12 ☔ View full report in Codecov by Sentry. |
zachaysan
commented
Nov 16, 2023
…troduce_dunning_billing_status
matthewelwell
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Introduce
billing_status
on theSubscription
model, which will be used to show users a dunning butterbar if a subscription has a payment failed event with dunning enabled. This is done by listening for two separate webhooks from chargebee, one for payment failures and the other for payment successes and updating the billing status accordingly.How did you test this code?
I used the webhook test feature built by chargebee to get the data format and added three new tests to cover the usecases. One test is a simple organisations list endpoint to ensure that the data is readable by a future JavaScript client.